Change license to Apache 2.0 #997
Merged
+203
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demirkayaender
requested review from
Groxx,
abhishekj720,
dkrotx,
natemort,
shijiesheng and
taylanisikdemir
as code owners
| @@ -1,4 +1,4 @@ | |||
| [submodule "src/main/idls"] | |||
| path = src/main/idls | |||
| url = git@github.com:uber/cadence-idl.git | |||
There was a problem hiding this comment.
did you mean to change this? This should be git@ as far as I'm aware
There was a problem hiding this comment.
Is that a java thing? Why should it be git@? All the other ones are using this format and it seems to be working.
This also seems to be working to me.
There was a problem hiding this comment.
it refs to the git cloning option, by default git uses SSH as a transport protocol, but you can use HTTP as well, though it's a bit less well supported.
There was a problem hiding this comment.
We should probably adopt a standard for this across our repos. AFAICT both of them are working and all the other repos use this one. We can switch to the other one in case this breaks in the future.
shijiesheng
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes